Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unit generics #115

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Remove unit generics #115

merged 5 commits into from
Jan 20, 2023

Conversation

g-bauer
Copy link
Contributor

@g-bauer g-bauer commented Jan 18, 2023 •
edited
Loading

This PR removes all generics, using SIUnit instead of the current generic EosUnit trait bound.

  • feos-core
  • feos-dft
  • feos-derive
  • feos

@g-bauer g-bauer marked this pull request as ready for review January 19, 2023 13:25
prehner
prehner approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@prehner prehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. I think we won't regret that.

@prehner prehner added this to the v0.4.0 milestone Jan 19, 2023
@prehner prehner merged commit 6b5c56a into main Jan 20, 2023
@prehner prehner deleted the remove_unit_generics branch January 20, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prehner prehner prehner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@g-bauer @prehner